zealvurte / SimSimMissionWin

WoW addon for the Shadowlands command table
GNU General Public License v3.0
4 stars 2 forks source link

Logs for verifications #11

Open LostTemple1990 opened 3 years ago

LostTemple1990 commented 3 years ago

logs.txt logs_2.txt some of these you may not interest in because they are not filtered covers 4 or 5 missions not verified

LostTemple1990 commented 3 years ago

SpecificLogsByMissionID.txt some of these may be included in files above

zealvurte commented 3 years ago

That's a whole lot of logs. 😮 I haven't got round to verifying anything in this batch, as the volume of them was hard for me to manually process (had to swap to a different IDE too).

Instead, I'm writing something to make processing, storing, accessing, and verifying a larger volume of logs easier before I get through them. Despite the now older build, they're still worthwhile, as only a few mission logs are invalid for the latest build.

LostTemple1990 commented 3 years ago

for easier to process a large amount of logs,I've written a parser to change a log file to a lua table in a lua file for parsing in game (it cost a large of time to paste a 5mb text in text area in addon UI) and output in a saved variable(It also cost a large of time to set a large text in text area of addonUI)

LostTemple1990 commented 3 years ago

SpecificLogs.txt

LostTemple1990 commented 2 years ago

sim error results and real logs.txt Is your sim run correctly for this log?

It seems that the heal effect will select a shroud target when the shroud target is not in full hp In turn 11,unit in slot 3 cast spell 48 and then get into shroud state In turn 12,unit in slot 0 cast heal spell to the unit in slot 3 in real log although it is in state shroud for heal spell 321,it's target in config is "3" sequence of the target logic is [0]="23104" units in slot 0,1 and 3 are existed in turn 12 according to the order of the sequence above,unit in slot 3 will be selected when the spell is casting the spell selected unit in slot 1 in sim because the unit in slot 3 is in shroud

I assume that the heal spell will always select the shroud unit when it is casting But I'm not sure which type of spell will select the shroud unit.. Only heal spell? or some buff spells(plusDamageTakenATK/modDamageDealt,etc..) will make the same result?

zealvurte commented 2 years ago

Is your sim run correctly for this log?

No, but now it is. 😁

GetTargets() is relatively dumb, as it only considers targeting type, and groups the list ones together, so it's not always considering if the target and source are friendly. This means it does checks for shrouds in cases where it shouldn't.

I assume that the heal spell will always select the shroud unit when it is casting But I'm not sure which type of spell will select the shroud unit.. Only heal spell? or some buff spells(plusDamageTakenATK/modDamageDealt,etc..) will make the same result?

AFAIK, same-side (friendly) targeting doesn't care if a target is shrouded or not (this effectively means all heals, as there's no enemy targetable heals). My GetTargetableTargets() that checks if something can cast was already written to handle this correctly, but it still relied on a call to GetTargets() to return an initial list of targets based on the targeting type, which unfortunately still excludes shrouded targets.

A quick rewrite of some of the no shroud checks in GetTargets() to pass if the source and target are friendly made this sim correctly.

LostTemple1990 commented 2 years ago

---------------------------------------------------------edit Good luck and enjoy your journey in real life~