search

zebrunner / mcloud-device

Android, Appium and STF provider in Docker.
10 stars 8 forks source link

improve ios device availability #146

Closed vdelendik closed 11 months ago

vdelendik commented 1 year ago

https://github.com/zebrunner/mcloud-device/pull/145/files#diff-4398bd4cabd7d1c063c4d3f7a973b9f6f27dfd06f3ac03d2f3fd5e26b6a52f72R27

I suppose it might be combined into the the single ios info --udid=... call. if info populated, device connected otherwise parse err: 

{"err":"Device '111' not found. Is it attached to the machine?","level":"fatal","msg":"error getting devicelist","time":"2023-08-25T02:11:45-07:00"}
vdelendik commented 1 year ago

done. it seems like better to test on mac starting manually not connected device, i.e. zebrunner-farm start 111

I suspect to see that it should echoing and exit with status 0:

    echo "Device is not available!"
    echo "Exiting without restarting..."
dhreben commented 1 year ago

Reopened

Steps:

  1. Disconnect device from mac
  2. docker ps -a - verify that containers are not available
  3. zebrunner-farm start 111

Actual result: The containers previous devices are started after run incorrect device udid zebrunner-farm start 111

creating...
57b1572bc28c9183976196e5f2cf841ed2c87869f9dfbbc4decc19ba40b0153f
1a77abb985d1c91df841f4979475157cc7842d9f28524ed9167a144849695940
c2f9b000609a4de45a07bce4e31086c5e33ac9e12f61d925d6a4c897ea91dfdd

device-- starting...
Error response from daemon: No such container: device--
Error: failed to start containers: device--
Error response from daemon: No such container: device---appium
Error: failed to start containers: device---appium
Error response from daemon: No such container: device---uploader
Error: failed to start containers: device---uploader
`docker ps -a`
CONTAINER ID  IMAGE                     COMMAND         CREATED     STATUS           PORTS   NAMES
c2f9b000609a  public.ecr.aws/zebrunner/mcloud-device:2.5.2  "/bin/sh -c 'bash /o…"  8 minutes ago  Exited (0) 8 minutes ago       device-iPhone_8-e18f63d.............5a50b1073bbbdeaddba8
1a77abb985d1  public.ecr.a..........bbdeaddba8-uploader
57b1572bc28c  public.ecr.aws/zebrunner/appium:2.0.2     "/opt/entrypoint/ent…"  8 minutes ago  Exited (0) 7 minutes ago       device-iPhone_8-e18f63............deaddba8-appium
vdelendik commented 1 year ago

verification should be applied on top of zebrunner-farm as well. moved to 2.6

vdelendik commented 11 months ago

it supposed to be fixed. but testing steps should be defined better

dhreben commented 11 months ago

Verified