search

zebrunner / mcloud-grid

Customized selenium-hub
6 stars 3 forks source link

raise exception asap is no device detected by udid in stf #115

Closed vdelendik closed 7 months ago

vdelendik commented 1 year ago

for the wireless devices we registered by ip address but in stf it was ip:5555. as result session request stuck in a queue and was cancelled by timeout only.

in case of such mismatch we have to raise exception asap and crash the session. just returning false is not enough because in this case we don't pay attention to the configuration mismatch

vdelendik commented 8 months ago

@akamarouski, please restest. it seems like with latest changes it should fail correctly asap without timeout. Also, make sure to test with true/false values for GRID_THROW_ON_CAPABILITY_NOT_PRESENT var.

as variant move verification onto the client side with smart timeouts per error.

akamarouski commented 7 months ago

Added checking is there device with such udid to the moment when we create node in grid. If there are no such device, we will raise GridException

For testing let's try to change device serial in RethinkDB

akamarouski commented 7 months ago

could not open RethingDB using UI and change device serial

dhreben commented 7 months ago

Will be tested on production