search

zebrunner / stf

Mirror for git@github.com:openstf/stf.git repository
Other
31 stars 18 forks source link

iOS: mismatch in model and product names. #918

Closed vdelendik closed 3 weeks ago

vdelendik commented 7 months ago

@ignacionar, please take a look onto the naming registration. it seems like with new approach we lost syncup for the Product column name.

image

it would be great to have everywhere the same name as in the yml configuration files.

ignacionar commented 7 months ago

Done: https://github.com/zebrunner/stf/pull/919,

remember to remove localstorage and cookies

vdelendik commented 7 months ago

merged, stf:2.6.4 republished

dhreben commented 7 months ago

Fixed

dhreben commented 1 month ago

Reopened Mismatch model and product names in STF and yml.file

dhreben commented 1 month ago

implemented for testing:

dhreben commented 1 month ago

Fixed

dhreben commented 1 month ago

Reopened

let’s implement the mapping in stf as set by the user in main.yml, both with and without _

vdelendik commented 1 month ago

fixed on mcloud-agent and mcloud-device levels: https://github.com/zebrunner/mcloud-device/issues/207, https://github.com/zebrunner/mcloud-agent/issues/359

current implementation inside stf is valid. @ignacionar, fyi^^

dhreben commented 1 month ago

implemented for testing:

dhreben commented 1 month ago

Reopened

Steps:

Mac case:

  1. Open main.yml - Enter name : iPhone_XR. -> with underscore - > Device is displayed without underscore
  2. Open main.yml - Enter name : iPhone SE -> with space - > Device isn't available on STF

Linux case:

  1. Open main.yml - Enter name : iPhone_11. -> with underscore - > Device is displayed without underscore
  2. Open main.yml - Enter name : iPhone 7 Plus -> with space - > Device isn't available on STF
dhreben commented 1 month ago

implemented for testing:

dhreben commented 4 weeks ago

Linux case:

  1. iPhone7 Plus ->device is available on STF
  2. iPhone 7 Plus -> device is available on STF
  3. iPhone_7 Plus -> device is available on STF
  4. Samsung_Galaxy_S22 -> device is available on STF
  5. Samsung Galaxy S22 -> device is available on STF
  6. Samsung _Galaxy S22 -> device is available on STF

Automation is tested with all cases, also tested iPhone_12(with underscore) and iPhone 12(with space) cases on 18 ios version.Basic acceptance successfully completed. Video, screenshots and logs are available.

Mac case:

Steps:

  1. Open main.yml
  2. Enter iOS device name with space -> iPhone SE
  3. Run ansible script
  4. ./zebrunner.sh start

Actual result: iOS containers are not up. Docker: invalid reference format: repository name must be lowercase.

solvd@idmcloud mcloud-agent % ./zebrunner.sh start

Device with udid: '00008030001C35AE3C42402E' was SUCCESSFULLY detected as connected.
grep: SE-00008..............2402E: No such file or directory
grep: SE-0000................402E: No such file or directory
grep: SE-000................402E: No such file or directory

    Creating '0000.............402E' containers:

wdaIpaPath: /Users/idmcloud/tools/WebDriverAgent.ipa
wdaBundleId: com.facebook.WebDriverAgentRunner.xctrunner

device-iPhone SE-0000...............C42402E-mitm:       docker: invalid reference format: repository name must be lowercase.
See 'docker run --help'.
already created
device-iPhone SE-00...............42402E-connector:  docker: invalid reference format: repository name must be lowercase.
See 'docker run --help'.
already created
device-iPhone SE-000.............3C42402E:            docker: invalid reference format: repository name must be lowercase.
dhreben commented 4 weeks ago

Moved to Ready for QA. Will be fix after https://github.com/zebrunner/mcloud-agent/issues/359

dhreben commented 3 weeks ago

Reopened

@azarouski Fyi @ignacionar Linux case:

  1. Open nano/roles/device/vars/main.yml

Mac case:

  1. Open nano/mac-roles/device/vars/main.yml
azarouski commented 3 weeks ago

@ignacionar about Linux case: For some devices we can see in response additional data and if these devices in DB - STF ignoring our custom name and gets name for them from this DB info. Please, pay attention to underscore.

dhreben commented 3 weeks ago

Implemented for testing:

dhreben commented 3 weeks ago

Still repro

Linux case:

iPhone_11 or iPhone_8 -> devices are available on STF, but displayed iPhone 11 or iPhone 8, but when used iPhone_11_2 or iPhone_8_2 -> 2 undersсores - STF is displayed correctly -> iPhone_11_2 or iPhone_8_2

dhreben commented 3 weeks ago

Implemented for testing:

dhreben commented 3 weeks ago

Fixed