invalid condition of 1st time device usage and as result width/height can't be detected

zebrunner / stf

Mirror for git@github.com:openstf/stf.git repository

Other

30 stars 18 forks source link

Closed vdelendik closed 3 months ago

vdelendik commented 3 months ago

in case of iOS 17 where we start wda independently via xcode we'va found a problem with width/height detection. it seems like we have a version but don't have sizes and as result this condition is broken: https://github.com/zebrunner/stf/blob/eae9a9adb3152d5e729dca3c564c7b6df3084191/lib/units/ios-device/plugins/group.js#L75

dhreben commented 3 months ago

Implemented for testing:

dhreben commented 3 months ago

Fixed