Discussion: Should the subscribe operator be a puller?

zebulonj / callbag-subscribe

A callbag sink (listener) that connects an Observer a-la RxJS. 👜

MIT License

18 stars 5 forks source link

Discussion: Should the subscribe operator be a puller? #2

Closed zebulonj closed 6 years ago

zebulonj commented 6 years ago

I'm inclined to think that callbag-subscribe should pull as well as listen. It'd have no effect if the source is just listenable (not pullable), but would ensure that it's operable with pullable sources.

staltz commented 6 years ago

Sounds reasonable. Pulling doesn't hurt in case the source is listenable, unless if you're really worried about performance in case of a busy listenable source, but even then the overhead would be negligible.