zecwalletco / zecwallet-mobile

Zecwallet Android and iOS apps
10 stars 11 forks source link

Wallet starts rescanning over and over #76

Closed pacu closed 2 years ago

pacu commented 2 years ago

Reproducing Steps:

expected: wallet rescans from 0% to completion and lets the user operate. result: wallets rescans from 0% to 99.9% and starts over rescanning

Version: v1.7.9 lightwalletd version ECC Lightwalletd 0.4.12

adityapk00 commented 2 years ago

Fixed in 7f16b0f566e3eac78e88eed69ef287b052d568e5, doing a new release.

r3ld3v commented 2 years ago

@adityapk00 I see the update in the iOS App Store to 1.7.12 about 14 hours ago. I had version 1.7.9 installed and when I deleted and reinstalled the app and restored my wallet, the app itself reports 1.7.9. The wallet still just repeatedly syncs.

zancas commented 2 years ago

@steven-ecc bullet point one of this documents an example of what we believe is the underlying issue.

We have a working version of the zecwallet-lite desktop application that resolves the issue by depending on upstream librustzcash, via our fork of zecwalletlitelib

pacu commented 2 years ago

I can report that the issue has not been fixed on 1.7.12

pacu commented 2 years ago

I just filed this issue. There might be an issue with the binary itself and the same version was uploaded instead of the one with the fixes. https://github.com/zecwalletco/zecwallet-mobile/issues/79

Credits to Steven Smith from ECC who found this issue.

zancas commented 2 years ago

Should this issue be reopened?

pacu commented 2 years ago

we believe it should. Since it does not seem to be fixed.

On Thu, Jun 2, 2022 at 4:51 PM Za Wilcox @.***> wrote:

Should this issue be reopened?

— Reply to this email directly, view it on GitHub https://github.com/zecwalletco/zecwallet-mobile/issues/76#issuecomment-1145280041, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADWFKGXWKUV5EPJADFOVGTVNEGCRANCNFSM5XORASVA . You are receiving this because you authored the thread.Message ID: @.***>

-- Francisco Gindre Software Developer

zancas commented 2 years ago

We have a version of zecwalletlitelib that does not have this issue:

https://github.com/zingolabs/zecwalletlitelib/releases/tag/vzing-0.0.1

We're currently working on a version of the Android app that depends on that library, which in turn depends on:

https://github.com/zcash/librustzcash