search

zed-extensions / kotlin

Syntax highlighting for Kotlin in Zed.
MIT License
22 stars 10 forks source link

Handle Offline case #23

Open 0xdeathbed opened 2 months ago

0xdeathbed commented 2 months ago

In case of no internet connectivity this fails: 

 let release = zed::latest_github_release(
            "fwcd/kotlin-language-server",
            zed::GithubReleaseOptions {
                require_assets: true,
                pre_release: false,
            },
        )?;

which end up giving Some("") . And resulting in lsp not starting even if present

cholwell commented 1 month ago

feel free to open a pr

when I have some time I can look if / how other extensions are handling this

0xdeathbed commented 1 month ago

Some are like this and some use local binary from PATH using worktee.