Shopify Liquid language support

zed-industries / extensions

Extensions for the Zed editor

840 stars 357 forks source link

Shopify Liquid language support #331

Closed RomainDW closed 2 months ago

RomainDW commented 6 months ago

Check for existing issues

[X] Completed

Language

Liquid

Tree Sitter parser link

https://github.com/Shopify/tree-sitter-liquid

Language server link

https://shopify.dev/docs/themes/tools/cli/language-server

Misc notes

No response

jeffreyguenther commented 5 months ago

Looks like that tree-sitter grammar has been archived. There is a recent fork: https://github.com/hankthetank27/tree-sitter-liquid.

This is what nvim-treesitter references.

Also, here's a direct link to the LSP package

Depending on how this extension is implemented, it might need to use that package directly. Using the Shopify CLI will bring with it a bunch of other tooling that might not be needed.

Close inspection is needed.

Symediane commented 4 months ago

Is it planned to have the same functionality as the VSCode extension?

Code formatting
Code completion and documentation on hover
Liquid tag, filter and object
HTML tag, attribute and value
Theme, section and block settings
Theme translation
Render tag snippet
Code navigation
Auto-closing pairs
Theme checks and fixes

jeffreyguenther commented 4 months ago

@Symediane I'd love for the extension to have all the same functionality. The tools are available to make it possible.

I personally don't have a concrete plan to tackle the rest of the build at the moment. More likely, I'll chip away at things over time. I'm totally game to accept PRs or sponsorships that would allow me to dedicate the time to the work.

mufftee commented 3 months ago

We need this so badly 😄

jeffreyguenther commented 3 months ago

We do! It would make using Zed a dream for Shopify development. Let's see what I can do after Editions.

Sanj718 commented 3 months ago

Thank you! the syntax highlighter is already great move and help! Will be waiting for further improvements! Thank you so much @jeffreyguenther

JosephTLyons commented 2 months ago

There is now a Liquid extension.

RomainDW commented 2 months ago

I don't think the extension was finished; it seems to me that the aim was to add the features listed by @Symediane

jeffreyguenther commented 2 months ago

Ya, that's correct. I started with Liquid syntax highlighting and am working towards creating an extension that does similar things to the official Shopify VSCode plugin. PRs are welcome on that repo. I'm chipping away at things between other projects.