zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
47.86k stars 2.8k forks source link

Invalid bindings cause other bindings fail #10144

Open failable opened 6 months ago

failable commented 6 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

With the below configs, the last invalid bindings will also cause the first two bindings fail to work.

[
  {
    "context": "Workspace",
    "bindings": {
      "ctrl-x ctrl-m": "command_palette::Toggle",
      "ctrl-cmd-l": "workspace::ToggleLeftDock",
      "ctrl-u ctrl x b": [ // Missing `-` between `ctrl` and `x`
        "tab_switcher::Toggle",
        {
          "select_last": true
        }
      ]
    }
  }
]

Environment

Zed: v0.130.0 (Zed Preview) OS: macOS 14.4.1 Memory: 32 GiB Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

Moshyfawn commented 6 months ago

Somewhat related to #9989.

asesh commented 5 months ago

Somewhat related to #9989.

@Moshyfawn @failable It is related. So it would make sense to close this one and track the other one instead?