search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
39.44k stars 2.05k forks source link

Extension-originated color theme is highlighted as "Value not accepted" in config.json #10235

Open osdrv opened 2 months ago

osdrv commented 2 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

A color theme from the extensions list called "macOS Classic Theme" is highlighted in the config pane and annotated as "Value is not accepted".

Here is a sequence of steps to reproduce the issue:

  1. Open Extensions pane.
  2. Find extension named macOS Classic Theme (GitHub: https://github.com/huacnlee/zed-theme-macos-classic).
  3. Install it.
  4. An automatic dropdown menu is expected to pop up, prompting to pick one of the 3 theme variations.
  5. Pick the "Light Theme" in the dropdown menu.
  6. The extension is expected to get applied.
  7. Open settings pane.
  8. theme setting is expected to be set to: "theme": "macOS Classic Light".
  9. The theme setting would be highlighted with a hint Value is not accepted. Valid values: ....

Expected behaviour: the color theme is applied with no warning in the config file.

Environment

Zed: v0.129.2 (Zed) OS: macOS 14.4.1 Memory: 16 GiB Architecture: aarch64

Extra specs: Zed version: 0.129.2 Zed build tag: 6866187d1eb2a7859424f77094cbce9469843503 OS version: MacOS 14.4.1 (23E224) Extension name: macOS Classic Theme Extension version: 0.0.6

If applicable, add mockups / screenshots to help explain present your vision of the feature

Screenshot 2024-04-06 at 15 38 09

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

slightlybelowzen commented 1 month ago

I did notice this, but I also saw that restarting zed seems to fix it (I'm guessing it needs to be restarted to find the themes installed from the extensions). Let me know if that fixes it.

If that doesn't work I'll take a look at the code to see what's going on. Another option (this is my preferred one since it doesn't involve downloading a bunch of themes I don't use) is to take the theme I like and just add it the ~/./config/zed/themes/ and use it like that.

You can find the themes you're using here.