search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
45.52k stars 2.49k forks source link

Inline git blame author (you logic) #10557

Open henrikruscon opened 4 months ago

henrikruscon commented 4 months ago

Check for existing issues

Describe the feature

Would be neat if the newly merged inline git blame could show "You" instead of your username if it is in fact you that is to blame. Just easier/faster to recognise at glance.

If applicable, add mockups / screenshots to help present your vision of the feature

CleanShot 2024-04-15 at 16 00 07@2x

social-anthrax commented 4 months ago

I'd personally be hesitant to do this, it's just a matter of time before someone would change their username to "you" to try and hide a commit. If this was togglable or had some visual difference from other usernames I'd be all for it.

jansol commented 4 months ago

I think there are some plans to add avatars, so one would have to change both their committer name and github avatar to impersonate someone.

But there definitely could be some additional highlight, maybe with the background color?

henrikruscon commented 4 months ago

Not really sure what's to gain from hiding your commit from inline code, you can simply hover the git blame and you will get all the details if it's really important in a very particular case. This is just a quality of life improvement. This is a none issue.

Calinou commented 1 month ago

One downside of showing "You" is that screenshots of the editor become less contextually relevant, so maybe it should just be highlighted in a different color but without changing the displayed name.

It's like having "x hours ago" in a screenshot with no date information :slightly_smiling_face: