zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
49.55k stars 3.03k forks source link

blade: crash on resize X11 #10563

Closed DissolveDZ closed 6 months ago

DissolveDZ commented 6 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

Resizing on X11 simply crashes Zed, probably due to outdated VK Swapchain here's the log:

    expected value at line 1 column 1
Thread "main" panicked with "called `Result::unwrap()` on an `Err` value: ERROR_OUT_OF_DATE_KHR" at /home/user/.cargo/git/checkouts/blade-b2bcd1de1cf7ab6a/810ec59/blade-graphics/src/vulkan/init.rs:812:18
   0: Zed::init_panic_hook::{{closure}}
             at zed/crates/zed/src/main.rs:740:29
   1: <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/alloc/src/boxed.rs:2029:9
      std::panicking::rust_panic_with_hook
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panicking.rs:785:13
   2: std::panicking::begin_panic_handler::{{closure}}
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panicking.rs:659:13
   3: std::sys_common::backtrace::__rust_end_short_backtrace
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/sys_common/backtrace.rs:171:18
   4: rust_begin_unwind
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panicking.rs:647:5
   5: core::panicking::panic_fmt
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/core/src/panicking.rs:72:14
   6: core::result::unwrap_failed
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/core/src/result.rs:1649:5
   7: core::result::Result<T,E>::unwrap
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/core/src/result.rs:1073:23
      blade_graphics::hal::init::<impl blade_graphics::hal::Context>::acquire_frame
             at .cargo/git/checkouts/blade-b2bcd1de1cf7ab6a/810ec59/blade-graphics/src/vulkan/init.rs:809:13
   8: gpui::platform::blade::blade_renderer::BladeRenderer::draw
             at zed/crates/gpui/src/platform/blade/blade_renderer.rs:524:13
   9: <gpui::platform::linux::x11::window::X11Window as gpui::platform::PlatformWindow>::draw
             at zed/crates/gpui/src/platform/linux/x11/window.rs:540:9
  10: gpui::window::WindowContext::present
             at zed/crates/gpui/src/window.rs:1112:9
      gpui::window::Window::new::{{closure}}::{{closure}}::{{closure}}
             at zed/crates/gpui/src/window.rs:474:33
      <gpui::app::AppContext as gpui::Context>::update_window::{{closure}}
             at zed/crates/gpui/src/app.rs:1310:26
      gpui::app::AppContext::update
             at zed/crates/gpui/src/app.rs:363:22
      <gpui::app::AppContext as gpui::Context>::update_window
             at zed/crates/gpui/src/app.rs:1301:9
      <gpui::app::async_context::AsyncAppContext as gpui::Context>::update_window
             at zed/crates/gpui/src/app/async_context.rs:94:14
      gpui::window::AnyWindowHandle::update
             at zed/crates/gpui/src/window.rs:2779:9
      gpui::window::Window::new::{{closure}}::{{closure}}
             at zed/crates/gpui/src/window.rs:472:30
  11: util::measure
             at zed/crates/util/src/util.rs:212:9
      gpui::window::Window::new::{{closure}}
             at zed/crates/gpui/src/window.rs:470:21
  12: <alloc::boxed::Box<F,A> as core::ops::function::FnMut<Args>>::call_mut
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/alloc/src/boxed.rs:2022:9
      gpui::platform::linux::x11::window::X11Window::refresh
             at zed/crates/gpui/src/platform/linux/x11/window.rs:296:13
      gpui::platform::linux::x11::client::X11Client::handle_event
             at zed/crates/gpui/src/platform/linux/x11/client.rs:216:17
      gpui::platform::linux::x11::client::X11Client::new::{{closure}}
             at zed/crates/gpui/src/platform/linux/x11/client.rs:147:29
      <core::cell::RefCell<calloop::sources::DispatcherInner<S,F>> as calloop::sources::EventDispatcher<Data>>::process_events::{{closure}}
             at .cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-0.12.4/src/sources/mod.rs:327:61
      <calloop::sources::generic::Generic<F,E> as calloop::sources::EventSource>::process_events
             at .cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-0.12.4/src/sources/generic.rs:290:9
      <core::cell::RefCell<calloop::sources::DispatcherInner<S,F>> as calloop::sources::EventDispatcher<Data>>::process_events
             at .cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-0.12.4/src/sources/mod.rs:326:9
  13: calloop::loop_logic::EventLoop<Data>::dispatch_events
             at .cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-0.12.4/src/loop_logic.rs:445:31
      calloop::loop_logic::EventLoop<Data>::dispatch
             at .cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-0.12.4/src/loop_logic.rs:559:9
      calloop::loop_logic::EventLoop<Data>::run
             at .cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-0.12.4/src/loop_logic.
rs:596:13
      <gpui::platform::linux::x11::client::X11Client as gpui::platform::linux::platform::LinuxClient>::run
             at zed/crates/gpui/src/platform/linux/x11/client.rs:530:9
  14: gpui::platform::linux::platform::<impl gpui::platform::Platform for P>::run
             at zed/crates/gpui/src/platform/linux/platform.rs:121:9
  15: gpui::app::App::run
             at zed/crates/gpui/src/app.rs:142:9
  16: Zed::init_ui
             at zed/crates/zed/src/main.rs:223:5
      Zed::main
             at zed/crates/zed/src/main.rs:439:9
  17: core::ops::function::FnOnce::call_once
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/core/src/ops/function.rs:250:5
      std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/sys_common/backtrace.rs:155:18
  18: std::rt::lang_start::{{closure}}
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/rt.rs:166:18
  19: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/core/src/ops/function.rs:284:13
      std::panicking::try::do_call
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panicking.rs:554:40
      std::panicking::try
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panicking.rs:518:19
      std::panic::catch_unwind
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panic.rs:142:14
      std::rt::lang_start_internal::{{closure}}
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/rt.rs:148:48
      std::panicking::try::do_call
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panicking.rs:554:40
      std::panicking::try
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panicking.rs:518:19
      std::panic::catch_unwind
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panic.rs:142:14
      std::rt::lang_start_internal
             at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/rt.rs:148:20
  20: main
  21: <unknown>
  22: <unknown>
  23: _start

Environment

Zed: v1.0.0 (Zed Dev da0d968a2cd558bf4957d837ed147b97bac06e1d) OS: Linux 1.0.0 Memory: 23.4 GiB Architecture: x86_64

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

already did

CalebHeydon commented 6 months ago

It looks like this is a duplicate of #9628

Moshyfawn commented 6 months ago

Thanks! I'm going to close this thread to keep the conversation in on place. Be sure to +👍 the other issue.

Duplicate of: