zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
49.96k stars 3.06k forks source link

blade: Outline rendering for 1 pixel borders is not being rasterized properly #11056

Open DissolveDZ opened 6 months ago

DissolveDZ commented 6 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

I tried Zed on Windows and have seen screenshots of it on Mac so i believe it's a Linux related issue on both X11 and Wayland. (Note that on Windows after some testing I've noticed the right side consistently being thinner, although it never disappears like on Linux)

The right side of any outline, which should be 1px in length both for popups and hollow cursor outline, doesn't show half of the time.

Environment

Zed: v1.0.0 (Zed Dev 2c1b961453fc721572d4600e7be66e15e85c197a) OS: Linux 1.0.0 Memory: 23.4 GiB Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

outline cursor half of the time: image

the other half it looks like this (right side thinner):

image

the exact same goes for hover popups, also always the right side. (couldn't take any screenshots because it kept on closing)

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

apricotbucket28 commented 6 months ago

I can also see rendering issues with some icons, here's from the inline git blame: image It only happens with some lines.

Edit: Here's the issue on the project panel image

DissolveDZ commented 6 months ago

this might be due to the zooming logic, at certain zoom levels it actually behaves perfectly as expected, squiggly lines and folding indicators also tend to break but at these levels everything is perfect.

example of one of those zoom levels

image

apricotbucket28 commented 6 months ago

Just got this while working on some X11 stuff. It mostly seems to happen with icons.

image

Edit: Another quick way to see this is with the LSP loading indicator at the bottom: image

kvark commented 2 months ago

Could somebody grab a RenderDoc capture of this happening, please, and share?