search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
50.9k stars 3.15k forks source link

LSP conformance issue - breaks some LSPs #11060

Open gdamore opened 7 months ago

gdamore commented 7 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

Some times Zed issues LSP messages to the LSP that contain:

{"jsonrpc":"2.0","id":1,"result":null,"error":null}

This is in violation of the LSP specification, which says that either result should be present, or error, but not both.

It causes the serve-d to crash - which admittedly it should not (serve-d is not following Postel's Law), but at the same time neither should zed issue illegal protocol (also not following Postel's Law.)

Environment

Zed: v0.133.2 (Zed Preview) OS: macOS 14.2.1 Memory: 128 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

github-actions[bot] commented 1 month ago

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and we will keep it open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, we'll close it in 7 days. Thanks for your help!