Closed smirzaei closed 1 week ago
Nice catch, thank you!
These don't seem to be the correct cursor styles to use in those places, VSCode for reference:
On macOS we use the row/colum style and in cases like these, I'd err on the side of visual consistency over perfect conformance with VSCode. But if there's a good semantic argument the other way I'd hear it @apricotbucket28
According to https://developer.mozilla.org/en-US/docs/Web/CSS/cursor#keyword, both should be fine. I do think they look a bit weird in Zed. Maybe old? Could be personal preference.
Resizing a window:
Table in LibreOffice
Table in Google Docs
ProtonMail
hmmm, that's a little tricky isn't it?
I guess it seems like the linux platform convention is closer to using the other style of cursor though, judging off of the 'resize window' icon, so maybe let's fix forward and swap back to the original ew/ns-resize
?
Yeah I agree. I don't see a lot of difference, most importantly I wanted the ability to use col-resize
and row-resize
cursors in GPUI.
Github also uses the col/row-resize
cursor style.
This PR fixes a small issue I noticed with resize cursors. The column/row resize cursors were missing and in a few places we were using
ew-resize
andns-resize
even though the documentation mentionscol-resize
androw-resize
.Finally updated the panes in the workspace to use the new column/row resize cursors.
Before:
After:
Release Notes:
ew-resize
for column resize andns-resize
for row resizeew-resize
andns-resize