[vim] use `editor: convert to xxx case` , Cannot undo correctly

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.

https://zed.dev

Other

34.47k stars 1.71k forks source link

[vim] use `editor: convert to xxx case` , Cannot undo correctly #11420

Open 0x2CA opened 1 week ago

0x2CA commented 1 week ago

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it

https://github.com/zed-industries/zed/assets/19868292/f4799904-8fc9-4008-a29e-d22c7000ff3e

Environment

Zed: v0.134.1 (Zed Preview) OS: macOS 14.2.1 Memory: 32 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your `~/Library/Logs/Zed/Zed.log` file to this issue.

No response

CharlesChen0823 commented 1 week ago

I think the problem is hit here, should not record new_selections? But these lines were added later from commit history, I don't what purpose.

ConradIrwin commented 1 week ago

Thanks for reporting! Currently we don't have a good way of adding extra functionality to the existing editor mappings, so vim mode gets undo/. etc but normal mappings don't. I'll think more about how we can resolve this without copy-pasting every action into vim.