Add a setting to keep brackets on the same line instead of a new line when formatting

[leftbones]

Check for existing issues

• [X] Completed

Describe the feature

I've noticed if you are putting something in brackets and you delete the closing bracket that Zed put there for you, then add one yourself, the open bracket is automatically moved one line down. Everyone has their own preferences, mine is to have all of the open brackets on the same line as the stuff before them, rather than the next line, a setting for this would be nice!

If applicable, add mockups / screenshots to help present your vision of the feature

https://github.com/zed-industries/zed/assets/77086654/4ce0aa60-614c-4331-bd94-2cf9930968b6

[0x2CA]

Hi, this is usually a formatting style setting for lsp, which should normally be achieved by configuring lsp to

[JosephTLyons]

Right - Zed isn't the thing making the changes in this case - which language server are you using?

[leftbones]

Right - Zed isn't the thing making the changes in this case - which language server are you using?

Ah! Sorry, I wasn't really sure, I need to study more about how language servers work in an application like Zed.

It looks like the C# extension in Zed uses OmniSharp, hopefully there's a way to customize this behavior! I know it has to be possible, because I've also used OmniSharp in Visual Studio Code and didn't have this problem.

[dyskette]

To configure omnisharp, you can use an omnisharp.json file. More information here: https://github.com/OmniSharp/omnisharp-roslyn/wiki/Configuration-Options

The location of the file is the following:

• On Windows: %USERPROFILE%\.omnisharp\omnisharp.json
• On Mac/Linux: ~/.omnisharp/omnisharp.json

Within the file you can enable .editorconfig support.

{
  "FormattingOptions": {
    "EnableEditorConfigSupport": true
  }
}

You might be interested in enabling the roslyn analyzers. That way zed shows warnings and code actions for omnisharp.

{
  "RoslynExtensionsOptions": {
    "enableAnalyzersSupport": true
  }
}

Zed's inlay hints can be enabled for omnisharp in the same json file with the inlayHintsOptions section, within the roslyn extension options.

{
  "RoslynExtensionsOptions": {
    "inlayHintsOptions": {
        "enableForParameters": true,
        "forLiteralParameters": true,
        "forIndexerParameters": true,
        "forObjectCreationParameters": true,
        "forOtherParameters": true,
        "suppressForParametersThatDifferOnlyBySuffix": false,
        "suppressForParametersThatMatchMethodIntent": false,
        "suppressForParametersThatMatchArgumentName": false,
        "enableForTypes": true,
        "forImplicitVariableTypes": true,
        "forLambdaParameterTypes": true,
        "forImplicitObjectCreation": true
    }
  }
}

The complete file can look like this:

{
  "FormattingOptions": {
    "EnableEditorConfigSupport": true
  },
  "RoslynExtensionsOptions": {
    "enableDecompilationSupport": true,
    "enableImportCompletion": true,
    "enableAnalyzersSupport": true,
    "inlayHintsOptions": {
        "enableForParameters": true,
        "forLiteralParameters": true,
        "forIndexerParameters": true,
        "forObjectCreationParameters": true,
        "forOtherParameters": true,
        "suppressForParametersThatDifferOnlyBySuffix": false,
        "suppressForParametersThatMatchMethodIntent": false,
        "suppressForParametersThatMatchArgumentName": false,
        "enableForTypes": true,
        "forImplicitVariableTypes": true,
        "forLambdaParameterTypes": true,
        "forImplicitObjectCreation": true
    }
  }
}

Notes:

• Decompilation support does not work in Zed, it only opens a blank tab when "go to definition" is selected. I think this might require custom support for specific omnisharp commands, just like omnisharp-extended-lsp extension exposes for neovim.
• Import completion does not work, and honestly I have not used it before for omnisharp in other editors, so... :woman_shrugging:

---

Once you have enabled .editorconfig support, create or edit an .editorconfig file in your project, and set formatting and analyzer options in there.

For example, to keep the braces in the same line for C# files:

[*.cs]
csharp_new_line_before_open_brace = none

• Formatting options: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/csharp-formatting-options
• Code quality rules: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/code-quality-rule-options
• Code style rules: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/code-style-rule-options

---

This is the result:

Cheers.