Hide Sign In - Githubissues

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.

https://zed.dev

Other

42.61k stars 2.27k forks source link

Hide Sign In #12325

Open Angelk90 opened 2 months ago

Angelk90 commented 2 months ago

Check for existing issues

[X] Completed

Describe the feature

It would be nice to have a property in the settings file that could hide this element.

If applicable, add mockups / screenshots to help present your vision of the feature

No response

RemcoSmitsDev commented 2 months ago

I think they don't want this, which makes sense: https://github.com/zed-industries/zed/pull/11802#pullrequestreview-2055715347

Angelk90 commented 2 months ago

@RemcoSmitsDev : But for me and many others it makes much more sense not to have it. If I don't want to connect Zed to my Github account now or in the future, it makes sense to me not to show it.

@maxdeviant : What's the point of showing display connection status indicator if I don't connect my github account?

iamnbutler commented 2 months ago

There are two things here:

Can we remove the sign in button in the titlebar?
Why does the no connection icon show up when I'm not signed in?

For the first, as has been mentioned above, it's unlikely we would consider removing this. Zed is collaborative software first, even if folks decide not to use those features.

For the latter, this feels incorrect. Logically, you shouldn't be able to be disconnected if you were never connected in the first place. @maxdeviant should there be a time when we show this even if the user hasn't authenticated?

Angelk90 commented 2 months ago

@iamnbutler : I understand that Zed started out as a workgroup editor, but how many people do you think use workgroup? If one wants something clean and wants to use it alone, then you say don't use zed?

As you can see from the screen I like clean things, I removed everything I don't use to have as much space as possible.

Then it is simply a matter of creating a key in the settegs by setting the default value that the Sign in is visible and then using an if in the code that checks the value of the json variable, whether to show the writing or not. I don't see anything so difficult it's impossible.