zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
39.31k stars 2.04k forks source link

Go test runner does not work with fish shell #12617

Open chrnorm opened 4 weeks ago

chrnorm commented 4 weeks ago

Check for existing issues

Describe the feature

I've just updated and discovered the new Go test runner feature. It looks great but unfortunately does not work by default on my machine. I am a fish user and I get the following error when running a test:

fish: Variables cannot be bracketed. In fish, please use {$ZED_CUSTOM_GO_P…}.
go test ${ZED_CUSTOM_GO_PACKAGE} -run $ZED_SYMBOL
         ^

⏵ Task `go test ./pkg/tokensvc -run Test_Service_Token` finished successfully
⏵ Command: '/Users/chrisnorman/.nix-profile/bin/fish -i -c `go test ./pkg/tokensvc -run Test_Service_Token`'

As a workaround I'd be very happy to use zsh or bash to execute these tests, I am not sure though which setting to change to switch the shell specifically for the Go tests.

If applicable, add mockups / screenshots to help present your vision of the feature

No response

osiewicz commented 4 weeks ago

This should be fixed on Wednesday (in a new Preview build).