search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
47.32k stars 2.74k forks source link

[Windows?] Ui font clipping top/bottom #12737

Closed MolotovCherry closed 2 months ago

MolotovCherry commented 3 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

Ui font size 14 is not cut, size 15 is. Unknown if this is Windows related or not, but it might be Windows specific

Don't know if this is related either, but my resolution is 3840x2160 @ 200% scale

{
  "buffer_font_size": 11,
  "buffer_font_family": "FiraCode NF",
  "ui_font_size": 14, // <-- change to 15
}

14 ✅

image

15 🚫 Notice the subtle clipping on the top and bottom

image

image

Environment

Zed: v0.140.0 (Zed Dev a574036efd13c0ae66ef3d0e57054e798fa1124e) OS: Windows 10.0.22631 Memory: 63.8 GiB Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

Moshyfawn commented 3 months ago

Can't seem to repo on MacOS.

JunkuiZhang commented 2 months ago

13854 may fix this issue. If not, please let me know.

MolotovCherry commented 2 months ago

13854 may fix this issue. If not, please let me know.

@JunkuiZhang I compiled and tested out your branch on my machine. I cannot reproduce the issue afterwards! Looks like that solved it.

JunkuiZhang commented 2 months ago

@MolotovCherry That's great :)