search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
49.58k stars 3.04k forks source link

`theme.mode: system` not respected #13537

Open RemiKalbe opened 4 months ago

RemiKalbe commented 4 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

Since the feature to automatically switch the theme based on the system appearance landed, it worked. Since—not sure how long—it stopped working for me. My settings.json contains the following:

"theme": {
    "mode": "system",
    "light": "Github Light",
    "dark": "Github Dark"
},

And yet, it always stays on Github Light, I tried using different combinations of themes, but without luck.

Environment

Zed: v0.140.5 (Zed) OS: macOS 14.5.0 Memory: 64 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

CleanShot 2024-06-25 at 23 01 24@2x

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

RemiKalbe commented 4 months ago

Edit: I believe the issue is that when the appearance changes while zed is opened, it still thinks it's in the previous mode? Not sure, I restarted it, and now it picks up the correct appearance, but I remember trying that already, and it did not work.

maxdeviant commented 4 months ago

I haven't been able to reproduce this.

RemiKalbe commented 4 months ago

I'll get back to you if I'm able to find a pattern to this issue, as it "seems" to be very random, but that's not a thing.

Aaron-212 commented 4 months ago

I also ran into this issue multiple times a couple of weeks ago, but I don't know how to reproduce it. macOS 15 beta 2, Zed 0.140

DragonDev1906 commented 3 months ago

I'm not sure if this is the right place, it might have not been implemented for Linux yet. So far I wasn't able to get theme.mode: system to work on Linux (gtk theme) and this one was the only issue related to that I could find.

# Command to set a theme
xfconf-query -c xsettings -p /Net/ThemeName

xfsettingsd is running in the background and Firefox does recognize and switch accordingly.

Zed: v0.143.7 (Zed) OS: Linux X11 arch unknown Memory: 31 GiB Architecture: x86_64

mabequinho commented 3 months ago

I'm not sure if this is the right place, it might have not been implemented for Linux yet. So far I wasn't able to get theme.mode: system to work on Linux (gtk theme) and this one was the only issue related to that I could find.

# Command to set a theme
xfconf-query -c xsettings -p /Net/ThemeName

xfsettingsd is running in the background and Firefox does recognize and switch accordingly.

Zed: v0.143.7 (Zed) OS: Linux X11 arch unknown Memory: 31 GiB Architecture: x86_64

It worked fine on F40 installed on a arch distrobox. Just notice it stopped. Edit: Installed using the script and works now