search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
48.05k stars 2.84k forks source link

blade: Text is rendered either too thick or too thin #13564

Open apricotbucket28 opened 3 months ago

apricotbucket28 commented 3 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

Ever since https://github.com/zed-industries/zed/commit/a89dc8c42efff8d746088a7b79fae14bf0d4eb78, text rendering has either been to thick or too thin, depending on the theme.

Screenshots

(they're not mine, I just took them from the Discord channel)

Dark theme

Before image After image

Light theme

Before image After image

Environment

Zed: v0.142.0 (Zed Nightly eb914682b39c154dca8d6352184afbf89b00f782) OS: Linux Wayland fedora 40 Memory: 30.5 GiB Architecture: x86_64

Since this is an issue with the Blade renderer, I can also reproduce on Windows.

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Zed.log
ajstarks commented 2 months ago

Workaround: setting "buffer_font_weight": 600 works for light mode themes.

ciaran-matthew-dunne commented 4 weeks ago

Following on from #14169, it appears Zed is having issues with font weights. Changing the buffer font weight is ineffective until 600, which also looks badly rendered.

Screenshot from 2024-09-09 17-00-47 Screenshot from 2024-09-09 17-01-01

Zed.log