zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
46.54k stars 2.64k forks source link

Deno LSP Stops Working with Multiple Projects in a Workspace #13664

Open crisadamo opened 2 months ago

crisadamo commented 2 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

When I create a workspace with multiple projects (folders), either all Deno or a mix of Deno/Node), Deno LSP stops working and does not recognize the configuration. Adding local settings to the project or the entire workspace does not resolve the issue. The only way to get the LSP working is to have a workspace with a single project (even a single folder does not work).

Steps to Reproduce:

  1. Create a workspace with multiple projects (folders).
  2. Ensure the projects are either all Deno or a mix of Deno and Node. You can clone fresh and saaskit for instance.
  3. Add to each project a local zed settings (you can do this for the whole workspace too):
    {
    "languages": {
    "TypeScript": {
      "language_servers": ["deno", "!typescript-language-server", "!vtsls", "!eslint", "..."]
    },
    "TSX": {
      "language_servers": ["deno", "!typescript-language-server", "!vtsls", "!eslint", "..."]
    }
    }
    }
  4. Attempt to use LSP features (e.g., code completion, linting) or navigate the files and you will see plenty of issues.
  5. Observe that LSP is not recognizing the configuration.

Environment

Zed: v0.141.3 (Zed) OS: macOS 14.5.0 Memory: 16 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Zed.log

sigmaSd commented 1 month ago

Should be fixed in https://github.com/zed-industries/zed/commit/e5dc6beace06f4a0aaa2649a39a8c2739a3db452

notpeter commented 1 day ago

Following up @crisadamo, was this fixed for you?