search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
49.46k stars 3.02k forks source link

Theme changing by itself #13938

Closed heyimnel closed 3 months ago

heyimnel commented 4 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

Zed changes my theme to One Dark by itself (e.g. after installing an extension or opening new zed window), even that i have different theme in settings.

Environment

Zed: v0.142.6 (Zed) OS: macOS 15.0.0 Memory: 8 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

JosephTLyons commented 4 months ago

Hey @heyimnel, would you be able to share the contents of your settings.json file?

heyimnel commented 4 months ago 
{
  "theme": "Rosé Pine",
  "diagnostics": false,
  "metrics": false
},
{
  "base_keymap": "VSCode",
  "theme": "Rosé Pine",
  "ui_font_size": 16,
  "buffer_font_size": 16
},
{
  "autosave": {
    "after_delay": {
      "milliseconds": 1000
    }
  }
},
{
  "features": {
    "copilot": true
  }
},
{
  "theme": {
    "mode": "dark",
    "dark": "Rosé Pine",
    "light": "One Light"
  }
},
{
  "git_status": true
}
juice49 commented 3 months ago

@heyimnel I experienced a similar problem. It seems to have been caused by subtle mistakes in my Zed config JSON that were previously ignored. After fixing them, everything is working again.

Does replacing your config with the following help?

{
  "diagnostics": false,
  "metrics": false,
  "base_keymap": "VSCode",
  "ui_font_size": 16,
  "buffer_font_size": 16,
  "autosave": {
    "after_delay": {
      "milliseconds": 1000
    }
  },
  "features": {
    "copilot": true
  },
  "theme": {
    "mode": "dark",
    "dark": "Rosé Pine",
    "light": "One Light"
  },
  "git_status": true
}
heyimnel commented 3 months ago

It doesn't, its the same as before

JosephTLyons commented 3 months ago

, { "git_status": true }

Can you try this? There were some things that were incorrect, but I'm not sure if correcting those will fix your problem or not:

{
  "telemetry": {
    "diagnostics": false,
    "metrics": false
  },
  "base_keymap": "VSCode",
  "ui_font_size": 16,
  "buffer_font_size": 16,
  "autosave": {
    "after_delay": {
      "milliseconds": 1000
    }
  },
  "features": {
    "inline_completion_provider": "copilot"
  },
  "theme": {
    "mode": "dark",
    "dark": "Rosé Pine",
    "light": "One Light"
  },
  "tabs": {
    "git_status": true
  }
}

We have cases where Zed just gives up if we fail to the parse the settings, so that's on us to try to make this easier. As a note, you can use this view to help see the structure of our defaults:

command palette > zed: open default settings

heyimnel commented 3 months ago

It helped, thanks