zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
46.78k stars 2.67k forks source link

Using ⌘⇧P doesn't trigger Command Palette in macOS Sequoia if Passwords app is active in menu bar #14474

Open Tom-Boscher opened 1 month ago

Tom-Boscher commented 1 month ago

Check for existing issues

Describe the bug / provide steps to reproduce it

When Passwords app in macOS Sequoia is active in menu bar, the default shortcut to toggle it is ⌘⇧P, same as Command Palette in Zed. When Zed window is focused, triggering ⌘⇧P should trigger Command Palette instead of triggering Passwords app.

Environment

Zed: v0.144.2 (Zed Preview) OS: macOS 15.0.0 Memory: 16 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

No response

notpeter commented 1 month ago

Hi, I don't currently have MacOS sequoia beta installed to test with. I'm not sure it will be possible to overide a MacOS handled shortcut. Can you confirm whether this also impacts VSCode (I would expect so).

My recommendation is to pick an alternate shortcut for Passwords or an alternate shortcut in Zed for command palette.

Dygear commented 1 month ago

Currently this seems to be a hard coded shortcut that we are unable to turn off currently in Sequoia Beta 3. This is an Apple issue. I've submitted Feedback on this and I recommend that @Tom-Boscher does the same as this is an undesirable outcome for the Passwords app to commandeer the Shortcut and for it to not be reassignable or allow users to turn it off. I for one am never going to use Passwords so much that I need it as a keyboard shortcut.

--- Edit ---

Found a solution. Open Passwords, the full app. Goto Passwords -> Settings (Or use Cmd + ,). The first checkbox is "Show Passwords in Menu Bar". Once you uncheck that, it stops taking over the Cmd + Shift + P shortcut.

image