zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
45.39k stars 2.48k forks source link

Add Powerline glyphs in Zed fonts #14476

Open matthprost opened 1 month ago

matthprost commented 1 month ago

Check for existing issues

Describe the bug / provide steps to reproduce it

I'm using Zed and zsh on my terminal, while opening the terminal inside Zed it seems like glyphs are not correctly interpreted since a recent update.

Here is how to reproduce:

  1. Install zsh on your terminal
  2. In your .zshrc file add ZSH_THEME="agnoster" to have the same theme as me
  3. Open zed and open the terminal panel
  4. You should see the following: Screenshot 2024-07-15 at 10 41 30

Note: it works perfectly fine in iTerm:

Screenshot 2024-07-15 at 10 45 07

Environment

Zed: v0.143.7 (Zed) OS: macOS 14.5.0 Memory: 16 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

No response

notpeter commented 1 month ago

From the agnoster-zsh-theme README

NOTE: In all likelihood, you will need to install a Powerline-patched font for this theme to render correctly.

To test if your terminal and font support it, check that all the necessary characters are supported by copying the following command to your terminal: echo "\ue0b0 \u00b1 \ue0a0 \u27a6 \u2718 \u26a1 \u2699". The result should look like this:

I'll convert this to an enhancement request for the Zed fonts to support those characters, but in the meantime you'll have to install a patched font and tell Zed to use that font with buffer_font_family in your settings.json.

matthprost commented 1 month ago

@notpeter Thanks your explanation and for your quick answer 👌

notpeter commented 1 month ago

FYI: Zed Mono (Iosevka derivative) is now available as a patched NerdFont which includes powerline glyphs. No Zed Plex Mono (IBM Plex derivative) yet, but fingers crossed.

brew install --cask font-zed-mono-nerd-font