zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
47.34k stars 2.75k forks source link

markdown preview: support for keystrokes #14830

Open xhyrom opened 2 months ago

xhyrom commented 2 months ago

Check for existing issues

Describe the feature

Add support for rendering <kbd> tags.

If applicable, add mockups / screenshots to help present your vision of the feature

zed: image

github: image

JosephTLyons commented 2 months ago

Hey @xHyroM, I'm assuming your images are swapped around and that it is Zed that isn't rendering the <...> bits?

xhyrom commented 2 months ago

Hey @xHyroM, I'm assuming your images are swapped around and that it is Zed that isn't rendering the <...> bits?

yeah, you're right. sorry!

bbb651 commented 2 months ago

I started working on this and while learning about "inline html" vs "block html" in commonmark I did some tests and apparently you can literally put anything you want inside kbd :

image

You can even nest multiple block levels kbds together github markdown is very drunk

(I don't think it should be implemented, it doesn't render in vscode and it just seems more complicated, It's fun to mess around with though)