search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
50.88k stars 3.15k forks source link

Clicking next arrow on text find controls works on the active pane rather than the pane with the text find controls #14838

Open ChaiTRex opened 4 months ago

ChaiTRex commented 4 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

  1. Open file editor pane.
  2. Split file editor pane into a second one.
  3. Use Zed's text find to find some text that appears at least twice in the first file editor pane.
  4. Use Zed's text find to find some text that appears at least twice in the second file editor pane.
  5. Click on some text in the first file editor pane to make that the active pane.
  6. Click the next button on the second file editor pane to move to the next found text in the second file editor pane.
  7. Notice that it instead went to the next found text in the first file editor pane.

Environment

Zed: v0.144.3 (Zed) OS: macOS 14.5.0 Memory: 8 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

Log file not provided because mouse activities and text find activities are not listed therein.
notpeter commented 4 months ago

I can reproduce this issue with Zed 0.146 on Mac. It appears when you have two panes open with two search contexts the next/previous buttons are not pane-specific, they always advance the search in the focused pane.

Thanks for reporting.

notpeter commented 4 months ago

Looks like this impacts Terminal too. See: