zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
50.55k stars 3.13k forks source link

Request for GTK theme support in Zed editor #14871

Open millan242 opened 4 months ago

millan242 commented 4 months ago

Check for existing issues

Describe the feature

It would be beneficial if the Zed editor could support GTK themes to provide a consistent user experience across the desktop environment.

Current Behavior: Zed editor uses its default theme regardless of the GTK theme applied to the system.

Desired Behavior: The Zed editor should automatically adopt the system-wide GTK theme, including font settings, window decorations, and color schemes, to ensure visual consistency with other GTK applications.

Use Case: Many users prefer a unified look and feel for their applications, especially those using GTK-based desktop environments like GNOME and XFCE.

Additional Information: Operating System: Ubuntu 24.04 LTS x86_64 GTK Theme: WhieSur GTK theme Zed Editor Version: 0.144.4

If applicable, add mockups / screenshots to help present your vision of the feature

Screenshot from 2024-07-20 22-58-12

apricotbucket28 commented 3 months ago

Implementing GTK theming would be a difficult task and probably not a good idea (mainly on the technical side). However, adding Freedesktop accent color support would be quite nice.

Here's a good article on the matter: https://cassidyjames.com/blog/freedesktop-accent-colors-gnome-proposal/

From https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.Settings.html:

org.freedesktop.appearance accent-color ((ddd)) Indicates the system’s preferred accent color as a tuple of RGB values in the sRGB color space, in the range [0,1]. Out-of-range RGB values should be treated as an unset accent color.

Also want to clarify:

font settings, window decorations

Those are not related to the GTK theme. I'm not sure what you mean by the latter, but the former can be fixed separately.

LSeelig commented 3 months ago

Those are not related to the GTK theme. I'm not sure what you mean by the latter, but the former can be fixed separately.

This refers to the bar at the top of the window, which has different close/minimize/maximize icons and layout from all GTK apps (and soon, QT apps as well). GNOME doesn't even support server-side decorations, so libdecor might be the only solution.

adityainduraj commented 3 months ago

Just saying, having a Gnome-GTK-ish top bar will go a long way in making Zed feeling much more integrated in the UI.

olumolu commented 3 months ago

And make sure use gtk4

Searge commented 1 month ago

Hello :wave:

Any progress/solution?

Searge commented 1 month ago

Related issue: https://github.com/zed-industries/zed/issues/14120