search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
46.93k stars 2.7k forks source link

theme: missing drop shadow when using blurred background #15383

Open tecandrew opened 1 month ago

tecandrew commented 1 month ago

Check for existing issues

Describe the bug / provide steps to reproduce it

latest version of Catppuccin theme exposed a strange behavior when blurred background is set. the drop shadow is missing on MacOS when this is enabled. seems like it happens across the board amongst any theme that uses this?

tested using this in settings.json

"experimental.theme_overrides": {
  "background.appearance": "blurred"
}

ref:

may be related to

Environment

Zed: v0.145.1 (Zed)
OS: macOS 14.5.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

(on plain white background)

image image

If applicable, attach your Zed.log file to this issue.

Zed.log
jansol commented 1 month ago

Yes, as mentioned in #10993 window shadows are explicitly disabled for transparent windows in GPUI since they completely destroyed resizing and exposé performance. Blur is based on a private API used by Terminal.app, which does have drop shadows with seemingly no performance problems. But since the APIs are private, there is no documentation for them and I have no idea what Terminal.app is doing differently (all my information is essentially from what winit does, which in turn is reverse engineered from somewhere else). If you find a way to have both transparency/blur and shadows, please do open a PR to fix it.