zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.

https://zed.dev

Other

46.78k stars 2.67k forks source link

Inconsistent names of snippet files #15460

Open failable opened 1 month ago

failable commented 1 month ago

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it

Not sure if this is a "bug". From here.

It's a bit unclear how to name the snippet file especially when there is whitespace in the language name.

For example,

For "lang" Plain Text, plaintext.json works while plain_text.json and plain text.json don't.
While for "lang" Git Ignore, git ignore.json works while gitignore.json and git_ignore.json don't.

Environment

Zed: v0.146.1 (Zed Preview) OS: macOS 14.5.0 Memory: 32 GiB Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

osiewicz commented 1 month ago

That's due to the fact that we "special case" text files: https://github.com/zed-industries/zed/blob/4bf2826655a849ac5b2ee6767f2e0e2bc8f625c5/crates/language/src/language.rs#L1388

amanaknows commented 1 month ago

That's due to the fact that we "special case" text files:

https://github.com/zed-industries/zed/blob/4bf2826655a849ac5b2ee6767f2e0e2bc8f625c5/crates/language/src/language.rs#L1388

Duhhhh stark what did you think?

amanaknows commented 1 month ago

deadlock

amanaknows commented 1 month ago

That's due to the fact that we "special case" text files:

https://github.com/zed-industries/zed/blob/4bf2826655a849ac5b2ee6767f2e0e2bc8f625c5/crates/language/src/language.rs#L1388

Bloberuuuuuunies

amanaknows commented 1 month ago

//This helps w clunky mess

osiewicz commented 1 month ago

@amanaknows please stop spamming this issue with seemingly unrelated comments.

amanaknows commented 1 month ago