Toggled off icons indent

[agorushkin]

Check for existing issues

• [X] Completed

Describe the feature

When disabling icons for files through project_panel.file_icons: false, the spaces remaining from the indent is MASSIVE. It would be nice if it worked like applying a display: none property in CSS.

If applicable, add mockups / screenshots to help present your vision of the feature

[notpeter]

Yeah, that's definitely a little ugly. (I was able reproduce on MacOS and Linux)

[uladkaminski]

I think here the goal is to have the same intend with the folders that anyway have icons. Otherwise it is hard to read the structure of the folders.

[uladkaminski]

I think it worth to make just a small point as a default icon for the all types of the files to make the layout more user friendly.

Here is the PR for that: https://github.com/zed-industries/zed/pull/16142

[SomeoneToIgnore]

Looks better now.

[SomeoneToIgnore]

@maxdeviant , could we get some ideas on how that should be implemented?

I do not think the originally proposed, placeholder icon is a good approach. No extra space seems to be bad too due to https://github.com/zed-industries/zed/pull/16167 , so what is a good one?

[maxdeviant]

@maxdeviant , could we get some ideas on how that should be implemented.

I do not think the originally proposed, placeholder icon is a good approach. No extra space seems to be bad too due to #16167 , so what is a good one?

@iamnbutler and I discussed just hiding the folder icon entirely when file icons are disabled, but we're not sure exactly what we want to do here yet.

[uladkaminski]

Happy to help here, just let me know what is the decision.

[JosephTLyons]

This is now available in today's preview build.