Closed everdrone closed 1 month ago
You should use powershell.exe
instead of pwsh.exe
You should use
powershell.exe
instead ofpwsh.exe
They resolve to different binaries, pwsh.exe
is more up to date
Is pwsh.exe
included in your PATH
environment variable? Typically, the terminal searches for pwsh.exe
within the PATH
environment variable.
Yes the path to pwsh.exe
is available in my PATH
The log file you attached doesn't seem to be complete. Could you try running a debug build, such as with cargo run
, and share the final error output?
BTW, is the following working?
"with_arguments": { "program": "C:\\full\\path\\to\\pwsh.exe", "args": "-nologo" }
I just installed the PowerShell
, and it works fine for me.
I guess you just installed PowerShell
and didn't restart your terminal?
BTW, what's the difference between PowerShell
and Windows PowerShell
?
@JunkuiZhang no, pwsh
has been installed on my system for a long time now.
I'll reproduce the issue and paste the full logs in 30 minutes or so, I pasted the section at the time of the incident and probably missed something.
I'll also try using the full path and report back.
Windows PowerShell
is version 5.1
, it's not actively developed anymore, pwsh
or PowerShell
is being maintained at https://github.com/PowerShell/PowerShell, so the difference is the builtin one is just a lot older than pwsh
, I have version 7.4.4
on my system
I see. Take your time, no rush. I'm currently in China, and it's already 3 AM here, so I'll be heading to bed. I'll be able to respond to your message in about 10 hours later.
Steps:
settings.json
(meaning no shell
key)settings.json
to include shell.with_arguments.program
as pwsh.exe
, args
to ["-nologo"]
cargo run
)After that I've set shell.with_arguments.program
to C:\\Program Files\\WindowsApps\\Microsoft.PowerShell_7.4.4.0_x64__8wekyb3d8bbwe\\pwsh.exe
, args
to ["-nologo"]
then cargo run
.
Also crashed.
This is weird I expected it to work with the full path to the powershell executable.
No log files were written in ~\AppData\Local\Zed\logs
when running the debug build
This is strange, I can not reproduce on my end.
https://github.com/user-attachments/assets/e1553d26-7494-445a-b93f-a9627c8ab7bd
Strange.. I just tried and if i set pwsh.exe
while zed is running it works.
It only crashes if i reopen it with those settings and if i had an open terminal pane when closing it the last time
Would you mind sharing your settings.json
file?
Sure, here
{
"theme": {
"mode": "system",
"dark": "Rosé Pine",
"light": "Rosé Pine Dawn"
},
"ui_font_size": 16,
"buffer_font_family": "Monaspace Neon",
// "buffer_font_family": "SF Mono",
// "buffer_font_weight": 500,
"buffer_font_features": {
"liga": false,
"calt": true,
"ss03": true,
"ss04": true
},
"buffer_font_size": 12,
"buffer_line_height": {
"custom": 1.7
},
"vim_mode": true,
"vim": {
"use_system_clipboard": "always"
},
"vertical_scroll_margin": 3,
"relative_line_numbers": true,
"tab_size": 4,
"remove_trailing_whitespace_on_save": true,
"ensure_final_newline_on_save": true,
"show_whitespaces": "selection",
"show_wrap_guides": false,
"indent_guides": { "enabled": false },
"languages": {
"Markdown": {
"formatter": "prettier"
}
},
"scrollbar": {
"show": "auto"
},
"inlay_hints": {
"enabled": false
},
"tabs": {
"file_icons": true
},
"terminal": {
"font_family": "Monaspace Neon",
// "font_family": "SF Mono",
"font_weight": 500,
"font_size": 13,
"dock": "bottom"
},
"assistant": {
"default_model": {
"provider": "copilot_chat",
"model": "gpt-4"
},
"version": "2"
},
"features": {
"inline_completion_provider": "none"
},
"telemetry": {
"diagnostics": false,
"metrics": false
}
}
Still can not reproduce even with your settings.
I think I'm having similar issue. Sometimes it works sometimes it just doesn't start. I use PowerShell as shell too (pwsh.exe one).
My environment is:
First time it compiles and started successfully, all consecutive runs it is failing. I tried to run:
cargo clean
cargo build --release
cargo run --release
Getting this following error:
> cargo run --release
warning: zed@0.154.0: Info: using 'ca2cce79edb68623f18d7b24f32446fcd04fb181' hash for ZED_COMMIT_SHA env var
Finished `release` profile [optimized + debuginfo] target(s) in 1.01s
Running `target\release\zed.exe`
error: process didn't exit successfully: `target\release\zed.exe` (exit code: 0xffffffff)
Compiled it in the debug and here is the trace:
@eng1n88r Would you mind sharing your settings.json
?
@eng1n88r Would you mind sharing your
settings.json
?
Could you point the location please?
Could you point the location please?
You can press ctrl+,
to open it, and paste the content here.
Could you point the location please?
You can press
ctrl+,
to open it, and paste the content here.
Zed is not starting unfortunately now. I was able to find it in c:\Users\%USER%\AppData\Roaming\Zed\
I think I found it:
Zed is not starting unfortunately now. I was able to find it in
c:\Users\%USER%\AppData\Roaming\Zed\
I think I found it:
Details
Oh great, sorry for the stupid advice...
@eng1n88r Could you try #17946 ? I'm thinking if it is just another bug of DispatcherQueue
, and I don't know why I just can not reproduce this bug on my end.
@eng1n88r Could you try #17946 ? I'm thinking if it is just another bug of
DispatcherQueue
, and I don't know why I just can not reproduce this bug on my end.
I checked out your PR and it WORKS for me!
I checked out your PR and it WORKS for me!
Great!
@everdrone Could you try the newest main branch to see if it is fixed ?
@everdrone Could you try the newest main branch to see if it is fixed ?
It worked! The issue seems resolved! Thank you @JunkuiZhang
It worked! The issue seems resolved! Thank you @JunkuiZhang
Good news!
Was going to ask when the PR will be merged and just noticed that it is already. I guess we need @everdrone to check and confirm if it fixed the issue.
Yes, it's fixed for me. I'll close.
Check for existing issues
Describe the bug / provide steps to reproduce it
Not sure why, but
shell
might crash the editor on startup (see attached video)To reproduce:
terminal.shell
insettings.json
terminal.shell
with:Environment
Zed: v0.150.0 (Zed Dev f7f5a255845b45ac33ab88bfdc023894034168b7) OS: Windows 10.0.22631 Memory: 63.1 GiB Architecture: x86_64 GPU: NVIDIA GeForce RTX 4090 || NVIDIA || 560.81
If applicable, add mockups / screenshots to help explain present your vision of the feature
https://github.com/user-attachments/assets/56e2b85c-c029-450b-a140-1dddc1d3d70e
If applicable, attach your Zed.log file to this issue.
Zed.log