search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
49.61k stars 3.04k forks source link

`Unsupported parameter: stop` for o1-* models #17990

Closed vladgabriel closed 1 month ago

vladgabriel commented 1 month ago

Check for existing issues

Describe the bug / provide steps to reproduce it

When trying to make an AI request using o1-* models I get an error from the OpenAI API: Unsupported parameter: stop is not supported with this model.

Steps to reproduce:

Environment

  Model Name: MacBook Pro
  Model Identifier: MacBookPro18,3
  Model Number: Z15H0001DZE/A
  Chip: Apple M1 Pro
  Total Number of Cores: 10 (8 performance and 2 efficiency)
  Memory: 32 GB
  System Firmware Version: 10151.61.4
  OS Loader Version: 10151.61.4

If applicable, add mockups / screenshots to help explain present your vision of the feature

image

If applicable, attach your Zed.log file to this issue.

No logs are outputted while executing the assistant request

maxdeviant commented 1 month ago

What version of Zed are you using?

This should be fixed in https://github.com/zed-industries/zed/pull/17796, which will be going to Preview today.

vladgabriel commented 1 month ago

This happens on Zed 0.153.6. I see that o1 is not mentioned in the release notes.

notpeter commented 1 month ago

@vladgabriel Support for o1 was included in v0.154.x. This is currently available in Zed Preview, see v0.154.0-pre release notes and will be available in Zed Stable on Wednesday.

You can safely download Zed Preview, check out the o1 support and it happily run alongside your existing Zed stable without conflict.

Note, you may wish to add max_completion_tokens to your settings to help control costs on your o1 request. See Zed Docs: Assistant: Configuration: OpenAI Custom Models for more.