search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
47.34k stars 2.75k forks source link

Autocomplete for functions omits parenthesises with vtsls language server #18014

Open s3bba opened 3 days ago

s3bba commented 3 days ago

Check for existing issues

Describe the bug / provide steps to reproduce it

This PR has introduced inconsistent behavior across language servers for JS/TS projects. Using vtsls server functions no longer get completed with parenthesises and function argument. Eg.: variable.functionName While if typescript-language-server is used we get expected behavior. Eg.: variable.functionName(args)

The first commit that has this issue is 02d5f320ad621e92cafaa7075f61e6496e12cd98

Environment

Zed: v0.154.0 (Zed Dev 2699fa8d4a10eb38445e0c5979dfb56a2193f949) OS: Linux X11 arch unknown Memory: 23.5 GiB Architecture: x86_64 GPU: AMD Radeon VII (RADV VEGA20) || radv || Mesa 24.2.2-arch1.1

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

No response

vdegenne commented 2 days ago

I have the same issue, I could swear I had autocompletion for functions with ts_ls before but even this server seems to ignore completion. So now I am not sure if that's an option to switch back on or something.