zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
48.85k stars 2.93k forks source link

Regression: TypeScript with Yarn PnP configuration not working in Zed v0.154.2 #18410

Open Brayan233 opened 4 weeks ago

Brayan233 commented 4 weeks ago

Check for existing issues

Describe the bug / provide steps to reproduce it

After upgrading to Zed v0.154.2, the TypeScript Yarn Plug'n'Play (PnP) configuration in local project settings (.zed/settings.json) stopped working. This setup was functional in Zed v0.153.7, but the recent update seems to have reverted the fix, causing the language server to ignore the local project settings.

Here is the local settings configuration that is not working:

{
  "lsp": {
    "vtsls": {
      "initialization_options": {
        "typescript": {
          "tsdk": ".yarn/sdks/typescript/lib"
        },
        "vtsls": {
          "autoUseWorkspaceTsdk": true
        }
      }
    }
  }
}

Steps to Reproduce:

  1. Upgrade to Zed v0.154.2.
  2. In the local project folder, create or update .zed/settings.json with the following configuration:
    {
    "lsp": {
    "vtsls": {
      "initialization_options": {
        "typescript": {
          "tsdk": ".yarn/sdks/typescript/lib"
        },
        "vtsls": {
          "autoUseWorkspaceTsdk": true
        }
      }
    }
    }
    }
  3. Start the editor and observe the behavior of the language server.

Expected Behavior:

The language server should pick up the configuration from the local project's .zed/settings.json and correctly use the specified TypeScript SDK path.

Actual Behavior:

The language server ignores the local .zed/settings.json settings. This results in the failure of the expected functionality in the project environment.

Additional Notes:

Related issues

Environment

Zed: v0.154.2 (Zed) OS: macOS 15.0.0 Memory: 16 GiB Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

No response

ai212983 commented 1 week ago

Any update on this? This is a showstopper for me, as it totally breaks TypeScript projects with Yarn PnP.