zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
48.29k stars 2.87k forks source link

Ruff code action "Fix all auto-fixable problems" does nothing #19077

Open fonnesbeck opened 1 day ago

fonnesbeck commented 1 day ago

Check for existing issues

Describe the bug / provide steps to reproduce it

When a line has a ruff error, the code action (lightning bolt icon) appears in the sidebar, which includes an option for ruff to "Fix all auto-fixable problems". However, selecting this option does not fix the issue. For example, a "line too long" error (see screenshot) should easily be auto-fixable, but the code does not change in the editor and the error message persists.

Environment

Zed: v0.156.1 (Zed) OS: Linux Wayland bluefin 40 Memory: 60.6 GiB Architecture: x86_64 GPU: AMD Radeon 780M (RADV GFX1103_R1) || radv || Mesa 24.1.7

If applicable, add mockups / screenshots to help explain present your vision of the feature

image

If applicable, attach your Zed.log file to this issue.

No response

notpeter commented 1 day ago

Anything in your Zed.log when this happens?

fonnesbeck commented 1 day ago

Nothing obvious? Here are the last few entries:

2024-10-11T11:20:48.292230518-05:00 [INFO] starting language server process. binary path: "/var/home/fonnesbeck/.local/share/zed/extensions/work/ruff/ruff-0.6.9/ruff-x86_64-unknown-linux-gnu/ruff", working directory: "/var/home/fonnesbeck", args: ["server"]
2024-10-11T11:21:38.218882225-05:00 [WARN] unhandled message: TaskStatus(SupermavenTaskUpdateMessage { task: "Initializing", status: Complete, percent_complete: None })
2024-10-11T11:21:38.219168074-05:00 [WARN] unhandled message: ActiveRepo(SupermavenActiveRepoMessage { repo_simple_name: None })
2024-10-11T11:21:55.590416766-05:00 [INFO] Summarizing updated entries took 5.71µs
2024-10-11T11:22:02.736834012-05:00 [ERROR] window not found
2024-10-11T11:22:02.736980688-05:00 [ERROR] window not found
2024-10-11T11:22:02.746769478-05:00 [ERROR] oneshot canceled
2024-10-11T11:22:09.004196962-05:00 [WARN] unhandled message: ActiveRepo(SupermavenActiveRepoMessage { repo_simple_name: Some("pymc") })
2024-10-11T11:22:09.004373184-05:00 [WARN] unhandled message: TaskStatus(SupermavenTaskUpdateMessage { task: "Adapting to 'pymc'", status: Complete, percent_complete: None })
2024-10-11T11:22:25.195859917-05:00 [ERROR] Failed to send events: HTTP 500

One reference to the ruff language server starting up.

Interestingly, for some problems the specific ruff issue shows up in the menu, and clicking on that fixes the problem: image

while the same problem (trailing whitespace) on another line does not have that option: image

In both cases, clicking on "fix all auto-fixable problems" does nothing.