search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
50.52k stars 3.13k forks source link

Bug for opening assistant chat while in a vim mode (normal or visual) #19994

Open TympanicLemon opened 3 weeks ago

TympanicLemon commented 3 weeks ago

Check for existing issues

Describe the bug / provide steps to reproduce it

While in normal or visual mode, if you open the assistant panel with a mapping (i used space ac and cmd+2), either of those will 80% of the time result in the window opening BUT my cursor doesnt appear so i have to still manually clcik on the window after opening it to focus the cursor onto it. Where as if I am in insert mode it works perfect fine, and when the window opens my cursor is there, but in normal mode

Environment

Zed: v0.159.5 (Zed) OS: macOS 15.0.1 Memory: 16 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
ConradIrwin commented 2 weeks ago

@TympanicLemon I cannot reproduce this. What do those bindings do exactly?

To test I added:

[
  {
    "bindings": {
      "cmd-2": "assistant::ToggleFocus"
    }
  }
]

to my keymap, but cmd-2 reliably focused the assistant for me.

TympanicLemon commented 2 weeks ago

Ah so you are right, cmd+2 consistently works (as of right now at least, or maybe I hallucinated it) but space ac doesn't

here is my keymaps

// Normal mode
{
    "context": "Editor && vim_mode == normal && !VimWaiting && !menu",
    "bindings": {
        "space a c": "assistant::ToggleFocus"
    }
}

// When nothing is open
{
    "context": "EmptyPane || SharedScreen", 
    "bindings": {
        "space a c": "assistant::ToggleFocus"
    }
}

Also after playing with it a bit, i think i a video might help a bit more, cause i can reproduce it.

TympanicLemon commented 2 weeks ago

https://github.com/user-attachments/assets/eb262fdc-744f-4ca9-aad1-87696026dc0c

Here is what I mean, maybe I am doing something dumb but i just did it 3 times in a row, so that feels, weird. Also to be clear, this is with the space a c mapping

ConradIrwin commented 2 weeks ago

Weird, I can also reproduce with space a c, but not cmd-2...

TympanicLemon commented 2 weeks ago

glad to know its not just me being crazy lol

TympanicLemon commented 1 week ago

Im guessing there is no fix for this you guys could find, its a very specific issue i guess, so fair enough