Disable File->Save All when there are no buffers to save - Githubissues

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.

https://zed.dev

Other

50.22k stars 3.08k forks source link

Disable File->Save All when there are no buffers to save #20599

Open renejsum opened 4 days ago

renejsum commented 4 days ago

Check for existing issues

[X] Completed

Describe the feature

A feature I appreciate in VSCode is that File->Save All is greyed out if all buffers are saved.

Environment

Zed: v0.160.7 (Zed) OS: macOS 12.7.6 Memory: 64 GiB Architecture: x86_64

If applicable, add mockups / screenshots to help present your vision of the feature

Coming from VSCode where it looks like this (1) But in Zed if all buffers are saved, I can still click Save All.

Which is nice to check before doing a code reload in docker compose, which takes several seconds

notpeter commented 4 days ago

We currently do very little updating of MacOS menu items dynamically at runtime. This means that various menu items are not disabled when they would be no-ops:

Edit->Undo/Redo
Go->Back/Forward
Go->Next Problem/Previous Problem
File->Close Window (when no windows are open)
File->Save All (this request)

Until recently this also affected unbinding keyboard shortcuts in the menus, but that has been fixed.