zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
50.6k stars 3.14k forks source link

Rename ime_key -> key_char and update behavior (cherry-pick #20953) #20957

Closed gcp-cherry-pick-bot[bot] closed 4 days ago

gcp-cherry-pick-bot[bot] commented 4 days ago

Cherry-picked Rename ime_key -> key_char and update behavior (#20953)

As part of the recent changes to keyboard support, ime_key is no longer populated by the IME; but instead by the keyboard.

As part of #20877 I changed some code to assume that falling back to key was ok, but this was not ok; instead we need to populate this more similarly to how it was done before #20336.

The alternative fix could be to instead of simulating these events in our own code to push a fake native event back to the platform input handler.

Closes #ISSUE

Release Notes: