This was a bug before about a patch ago, until it was eventually fixed. But I guess its an issue again.
Basically, a task is executed like lazygit, through a key map. When I hit q to exit lazygit it SHOULD hide/close the terminal completely, and it doesn't. (It def used to do this, and should as far as the behavior for the hide on success option should work.
Also for whatever reason, it always opens a new terminal rather than using the current one. I will provide a picture of what I mean for this:
You can see the two tabs, where I should only see one. I wonder if that has to due with the issue of it not closing after "success", but I digress.
Here is the relevant code for the task, and the keymap I use:
[
{
"label": "lazygit",
"command": "lazygit",
"hide": "on_success"
}
]
Check for existing issues
Describe the bug / provide steps to reproduce it
This was a bug before about a patch ago, until it was eventually fixed. But I guess its an issue again. Basically, a task is executed like lazygit, through a key map. When I hit q to exit lazygit it SHOULD hide/close the terminal completely, and it doesn't. (It def used to do this, and should as far as the behavior for the hide on success option should work.
Also for whatever reason, it always opens a new terminal rather than using the current one. I will provide a picture of what I mean for this:
You can see the two tabs, where I should only see one. I wonder if that has to due with the issue of it not closing after "success", but I digress.
Here is the relevant code for the task, and the keymap I use: [ { "label": "lazygit", "command": "lazygit", "hide": "on_success" } ]
{ "context": "Editor && vim_mode == normal && !VimWaiting && !menu", "bindings": { "space g g": ["task::Spawn", { "task_name": "lazygit" }] } }
(For what it's worth, this happens regardless of how I spawn the task, so with this key-map or through the spawn tasks menu in the command panel)
Environment
Zed: v0.162.3 (Zed) OS: macOS 15.1.0 Memory: 16 GiB Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your Zed.log file to this issue.
Zed.log
``` ```