search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
51.03k stars 3.17k forks source link

Text invisible with CommitMono #21271

Open undecided opened 6 days ago

undecided commented 6 days ago

Check for existing issues

Describe the bug / provide steps to reproduce it

After auto-updating to v0.163.2, suddently all the text in my buffers disappeared.

Workaround: Change font from CommitMono - even invalid font names fallback to a valid font, CommitMono appears to be the only font that is breaking on my machine Reproduce: Choose CommitMono. Checked font in other apps, and the font loads correctly there. Tried downloading and installing a fresh copy from https://commitmono.com - fallback loaded until I restarted zed, then all the glyphs disappear again

Environment

Zed: v0.163.2 (Zed) OS: Linux X11 linuxmint 22 Memory: 62.6 GiB Architecture: x86_64 GPU: Intel(R) Xe Graphics (TGL GT2) || Intel open-source Mesa driver || Mesa 24.0.9-0ubuntu0.2

(also happens on v0.164.0 (Zed Preview) )

If applicable, add mockups / screenshots to help explain present your vision of the feature

image (I should note for clarity, the shadow of text behind the file tree is a different project on a window that hasn't been redrawn since I changed the font back to commit mono - just bleeds through due to window transparency)

If applicable, attach your Zed.log file to this issue.

Zed.log (I've just added a snippet of the log - it's all identical, with the exception of the `GlyphId(x)` ). I'd guess there's one for every character it has tried to render) ``` 2024-11-28T09:53:11.81495478Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(1063), font_size: 12 px, subpixel_variant: Point { x: 1, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. } 2024-11-28T09:53:11.814989064Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(1055), font_size: 12 px, subpixel_variant: Point { x: 1, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. } 2024-11-28T09:53:11.815060832Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(565), font_size: 12 px, subpixel_variant: Point { x: 1, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. } 2024-11-28T09:53:11.815092887Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(874), font_size: 12 px, subpixel_variant: Point { x: 1, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. } 2024-11-28T09:53:11.815124361Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(906), font_size: 12 px, subpixel_variant: Point { x: 0, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. } 2024-11-28T09:53:11.81515559Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(906), font_size: 12 px, subpixel_variant: Point { x: 0, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. } 2024-11-28T09:53:11.815186751Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(906), font_size: 12 px, subpixel_variant: Point { x: 0, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. } 2024-11-28T09:53:11.81521901Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(906), font_size: 12 px, subpixel_variant: Point { x: 0, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. } 2024-11-28T09:53:11.815249645Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(906), font_size: 12 px, subpixel_variant: Point { x: 0, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. } ```
CharlesChen0823 commented 5 days ago

~this might relate #19772 i guess~

update: this is introduce by #20842

david-umd commented 1 day ago

i'm having the same issue with commit mono, have never ran into this on any other situation. used to work fine in zed until updating recently. zed's log looks the same as the original poster.

environment: Zed: v0.163.2 (Zed) OS: Linux Wayland arch unknown Memory: 15.3 GiB Architecture: x86_64 GPU: Intel(R) UHD Graphics 620 (WHL GT2) || Intel open-source Mesa driver || Mesa 24.2.7-arch1.1

CharlesChen0823 commented 22 hours ago

I had found the way to fixed the problem. will send a pr, but don't known if zed team will accepts.