search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
42.12k stars 2.21k forks source link

`"active_pane_magnification": 1.5` causes vertical splits to not use up entire height when inactive #4265

Open sxn opened 6 months ago

sxn commented 6 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

The title's not great, but hopefully reproduction steps + a video do a better job.

  1. Set active_pane_magnification to something other than the default (in my case, it's 1.5)
  2. Open a single editor
  3. Split the editor right
  4. Split the same editor down

You should have this:

SCR-20240116-paga

Now, clicking any of the editors on the left will work fine, using up the entire height. However, clicking the editor on the right will cause the previously selected editor to shrink, but the two editors will not end up taking the entire height. The video should hopefully clarify it better. 😅

https://github.com/zed-industries/community/assets/1155589/821b1b65-92bd-4b01-a7c0-10228f601016

This works as I'd expect in non-preview Zed.

Environment

Zed: v0.119.8 (Zed Preview) OS: macOS 14.3.0 Memory: 64 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

iamnbutler commented 5 months ago

I think this setting is pretty broken in zed2 in general - it also causes the tab/tool bars of splits to be sized incorrectly