search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
46.52k stars 2.63k forks source link

Hover tooltips should always consume scroll events when the mouse cursor is on them #4414

Open jansol opened 10 months ago

jansol commented 10 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

When hovering on a symbol, Zed shows some LSP-provided documentation for that symbol. Sometimes that documentation is too long to fit in the popup, so it is common to move the mouse over the popup and scroll through it.

Once you scroll to the end, the tooltip contents simply stop scrolling and nothing else happens. HOWEVER if the content does not overflow in the first place, i.e. there is nothing to scroll, moving the mouse over the tooltip and scrolling ends up scrolling the file behind the tooltip instead, dismissing the tooltip instantly. I often move the mouse over tooltips and absentmindedly give them a little nudge with the scroll wheel out of habit. The whole file scrolling and the tooltip disappearing is very distracting whenever this occurs and makes the behavior of tooltips unpredictable.

What I would expect instead is that the tooltip always consumes scroll events when the mouse cursor is on top of it. Additionally it should give a visual indication that there is nothing left to scroll through. (a thin line that pulses briefly on the edge of the tooltip where the end was reached or something similar)

Environment

Zed: v0.109.0 (preview) OS: macOS 12.7.0 Memory: 16 GiB Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

JosephTLyons commented 10 months ago

This is a very annoying papercut that I run into all the time. Thanks for making such a clean report @jansol!