search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
50.08k stars 3.07k forks source link

Key binding to navigate to search result broken in jetbrains mapping #4619

Open tychedelia opened 1 year ago

tychedelia commented 1 year ago

Check for existing issues

Describe the bug / provide steps to reproduce it

The binding here: https://github.com/zed-industries/keymaps/blob/master/src/jetbrains.json#L51C8-L51C8 overrides the ability to navigate to a search result via the keyboard in the global project search. The correct key binding in IntelliJ for navigating to a search result would just be enter. Note that IntelliJ also allows editing within a search pane, but requires clicking into the editor space first, so by default arrow keys move between the results and enter navigates to that result. No idea if this interacts negatively with other editor features.

Environment

Zed: v0.95.2 (stable) OS: macOS 13.3.1 Memory: 32 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

tychedelia commented 1 year ago

Alternatively, just making it so the default mapping works in search panel would be totally acceptable. It's just a pain right now to have to click on a search result to navigate there.

github-actions[bot] commented 1 month ago

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. Are you able to reproduce this issue in the latest version of Zed? If so, please let us know by commenting on this issue and we will keep it open; otherwise, we'll close it in a week. Feel free to open a new issue if you're seeing this message after the issue has been closed. Thanks for your help!

tychedelia commented 1 month ago

This is still an issue.