search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
50.35k stars 3.1k forks source link

Zoom doesn't work on German keyboard layout. #4981

Open sknauff opened 1 year ago

sknauff commented 1 year ago

Check for existing issues

Describe the bug / provide steps to reproduce it

With a German keyboard layout, pressing cmd and - decreases the zoom level, cmd and 0 resets the default, but cmd and + does not increase the zoom level.

Switching to US-Layout (ABC-Extended), all commands work as expected.

Environment

Zed: v0.74.3 (stable) OS: macOS 13.2.1 Memory: 32 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

jansol commented 1 year ago

Also happens with Nordic layout. To make matters worse, I can't bind "cmd-+" manually either. In this layout + is on its own key on the right side of the number row 0, where Apple's US layout appears to have minus and underscore. The key that is = and + on the US layout OTOH is a dead key in my layout, used for backtick and forward tick (`´).

The default binding seems to be "cmd-=" whicht requires pressing cmd-shift-0 which is a bit awkward (= is typed with shift-0). However pressing that combination DOES increase font size.

github-actions[bot] commented 1 month ago

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. Are you able to reproduce this issue in the latest version of Zed? If so, please let us know by commenting on this issue and we will keep it open; otherwise, we'll close it in a week. Feel free to open a new issue if you're seeing this message after the issue has been closed. Thanks for your help!

sknauff commented 1 month ago

It is fixed for the German keyboard layout and works as expected.