search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
50.21k stars 3.08k forks source link

Screen sharing notification with two monitors #5137

Closed exalted closed 1 month ago

exalted commented 2 years ago

Check for existing issues

Describe the bug / provide steps to reproduce it

When I have multiple monitors attached (in my case two) @as-cii sent me a screen sharing collaboration request. Each monitor have shown a notification popup on the upper right corner (similar to a macOS native ones), one of which I then accepted (the one on my "main" monitor, I believe).

However, the other notification didn't disappear and was still able to accept (or reject) the screen sharing request even after having left the previously accepted sharing session.

This is definitely an UX issue, however might also be seen as a security/privacy issue to some extent, because basically the invitee, although seemingly disconnected, can potentially re-join a screen sharing session, which, the invited thinks was already closed.

Expected behavior

I guess either a single notification should appear overall, or when accepted, either one of the notifications or all others should disappear.

Either way, I think it's much more important that, at some point (possibly on the server side), when an invitation was already accepted/rejected, the same invitation (e.g. link/id/ref) shouldn't be able to be used again, possibly even a expiration might be a good idea to implement :two-cents:)

Environment

Zed 0.62.8 – /Applications/Zed.app macOS 13.0 architecture arm64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue

No response

github-actions[bot] commented 1 month ago

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. Are you able to reproduce this issue in the latest version of Zed? If so, please let us know by commenting on this issue and we will keep it open; otherwise, we'll close it in a week. Feel free to open a new issue if you're seeing this message after the issue has been closed. Thanks for your help!

github-actions[bot] commented 1 month ago

This issue was closed due to inactivity; feel free to open a new issue if you're still experiencing this problem!