search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
49.42k stars 3.01k forks source link

Swiping across screens unfollow collaborator #5256

Open fdionisi opened 2 years ago

fdionisi commented 2 years ago

Check for existing issues

Describe the bug

When swiping across multiple screens/apps (three fingers swipe on the trackpad), occasionally, Zed unfollows the collaborator.

To reproduce

I'm afraid the reproduction steps may be broken - I'll try to ensure the reproduction between today and tomorrow. But:

  1. Set Zed as full-screen
  2. Join a collaborative session
  3. Follow your host
  4. Swipe to another screen/app
  5. Swipe back to Zed

Expected behavior

You are still following your collaborator

Environment

Zed 0.49.1 – /Applications/Zed.app macOS 12.1 architecture arm64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue

No response

fdionisi commented 2 years ago

@JosephTLyons, were you able to reproduce it? I returned to say that I spent the last 15 minutes trying this out but without any luck.

I now suspect that while swiping between apps, I may have scrolled on the buffer where I was following, which triggered the unfollow.

I get that's something similar to Miro or Figma, but I feel it's too easy to trigger unfollow collaborator.

JosephTLyons commented 2 years ago

I haven't actually tested this to see if I could reproduce it, I just added tags to the issue. I'm not currently in a place where I can easily test collaboration features - hoping this changes a bit going forward.

fdionisi commented 2 years ago

Gotcha! We can organise a session or two if you wish to test Zed collaboratively and like to pair program. I really look forward to using Zed's collaborative features more!

github-actions[bot] commented 1 month ago

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. Are you able to reproduce this issue in the latest version of Zed? If so, please let us know by commenting on this issue and we will keep it open; otherwise, we'll close it in a week. Feel free to open a new issue if you're seeing this message after the issue has been closed. Thanks for your help!