zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
47.33k stars 2.74k forks source link

font_family no longer changes terminal font (fixed: documentation is a bit confusing) #6366

Closed zxaos closed 10 months ago

zxaos commented 10 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

Setting font_family no longer changes the terminal font, it falls back to the buffer_font

Environment

Zed: v0.111.6 (stable) OS: macOS 14.0.0 Memory: 32 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

1: Monaspace Neon working in buffer, no font_family set. Screenshot 2023-11-11 at 16 04 01

2: Change buffer font to Hack Nerd Font Mono, see both terminal and buffer change: Screenshot 2023-11-11 at 16 05 14

3: Switch buffer_font_family to Monaspace and font_family to Hack Nerd Font Mono, note that the terminal also changes despite the new setting: Screenshot 2023-11-11 at 16 06 39

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

Zed.log

gldtn commented 10 months ago

I believe you have to set it to the terminal explicitly like so:

"terminal": {
        "font_family": "FiraCode Nerd Font",
        "font_size": 16
    }

See: https://docs.zed.dev/configuration/configuring-zed#terminal

zxaos commented 10 months ago

I believe you have to set it to the terminal explicitly like so:

That did it, thanks! That's easy to miss if you're just searching for font in the docs rather than reading them fully.